[PATCH] D88339: [XCOFF] Enable -fdata-sections on AIX

Jason Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 25 14:08:59 PDT 2020


jasonliu created this revision.
jasonliu added reviewers: daltenty, hubert.reinterpretcast, DiggerLin, Xiangling_L.
Herald added subscribers: llvm-commits, kbarton, hiraditya, nemanjai.
Herald added a project: LLVM.
jasonliu requested review of this revision.

Some design decision worth noting about:

I've noticed a recent mailing discussing about why string literal is not affected by -fdata-sections for ELF target:
http://lists.llvm.org/pipermail/llvm-dev/2020-September/145121.html

But on AIX, our linker could not split the mergeable string like other target. 
So I think it would make more sense for us to emit separate csect a mergeable string in -fdata-sections mode,
as there might not be other ways for linker to do garbage collection on unused mergeable string.


https://reviews.llvm.org/D88339

Files:
  llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
  llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
  llvm/test/CodeGen/PowerPC/aix-xcoff-data-sections.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88339.294422.patch
Type: text/x-patch
Size: 17213 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200925/698ea012/attachment.bin>


More information about the llvm-commits mailing list