[PATCH] D85393: [IR] Adds mustprogress as a LLVM IR attribute

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/AsmParser/LLParser.cpp:1371
+      B.addAttribute(Attribute::MustProgress);
+      break;
 
----------------
It looks like the simple attributes are sorted alphabetically above. Can you please insert this at the alphabetical position?


================
Comment at: llvm/lib/AsmParser/LLParser.cpp:1754
       break;
+    case lltok::kw_mustprogress:
+      HaveError |=
----------------
Just add this to the preceding case list?


================
Comment at: llvm/lib/AsmParser/LLParser.cpp:1874
+          Error(Lex.getLoc(), "invalid use of function-only attribute");
+      break;
     }
----------------
Same here, add this to the existing "invalid use of function-only attribute" case list?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85393/new/

https://reviews.llvm.org/D85393