[PATCH] D88323: [WebAssembly] Check features before making SjLj vars thread-local

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 25 11:08:36 PDT 2020


dschuff added inline comments.


================
Comment at: llvm/include/llvm/Target/TargetMachine.h:114
   StringRef getTargetFeatureString() const { return TargetFS; }
+  void setTargetFeatureString(StringRef FS) { TargetFS = std::string(FS); }
 
----------------
where does the feature string usually get initialized? just during TM construction? Is there any particular risk in allowing it to be changed after init?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88323/new/

https://reviews.llvm.org/D88323



More information about the llvm-commits mailing list