[PATCH] D88313: [flang] Failed call to CHECK() for call to ASSOCIATED(NULL())

[Pete Steinfeld via Phabricator via llvm-commits]

PeteSteinfeld created this revision.
PeteSteinfeld added reviewers: klausler, tskeith.
Herald added a reviewer: DavidTruby.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
PeteSteinfeld requested review of this revision.

Calling "ASSOCATED(NULL()) was causing an internal check of the compiler to
fail.

I fixed this by changing the entry for "ASSOCIATED" in the intrinsics table to
accept "AnyPointer" which contains a new "KindCode" of "pointerType".  I used
this new "KindCode" to change the function "FromActual()" which to return a
typeless intrinsic when called on a pointer.  This let me differentiate the
analysis of procedure arguments from explicit data arguments and do the right
thing in both cases.

I also added some tests.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D88313

Files:
  flang/include/flang/Evaluate/characteristics.h
  flang/include/flang/Evaluate/type.h
  flang/lib/Evaluate/characteristics.cpp
  flang/lib/Evaluate/intrinsics.cpp
  flang/lib/Semantics/check-call.cpp
  flang/test/Semantics/resolve89.f90

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88313.294337.patch
Type: text/x-patch
Size: 7754 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200925/a23c4788/attachment.bin>