[PATCH] D87700: [SVE] Replace / operator in TypeSize/ElementCount with coefficientDiv

Paul Walker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 25 03:42:31 PDT 2020


paulwalker-arm added inline comments.


================
Comment at: llvm/unittests/CodeGen/ScalableVectorMVTsTest.cpp:66
   EXPECT_EQ(EVT::getVectorVT(Ctx, MVT::i64, EltCnt * 2), MVT::nxv4i64);
-  EXPECT_EQ(EVT::getVectorVT(Ctx, MVT::i64, EltCnt / 2), MVT::nxv1i64);
+  EXPECT_EQ(EVT::getVectorVT(Ctx, MVT::i64, EltCnt.coefficientDiv(2)),
+            MVT::nxv1i64);
----------------
paulwalker-arm wrote:
> If `halve` is kept then it makes sense to add an explicit test for it here.
Oops, please ignore what looks like a stale review comment :(


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87700/new/

https://reviews.llvm.org/D87700



More information about the llvm-commits mailing list