[llvm] f11f382 - [AMDGPU] Fix declaration parameter names to match definition

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 25 03:40:07 PDT 2020


Author: Jay Foad
Date: 2020-09-25T11:38:17+01:00
New Revision: f11f382523e096859571b61520af81b9bb1defbf

URL: https://github.com/llvm/llvm-project/commit/f11f382523e096859571b61520af81b9bb1defbf
DIFF: https://github.com/llvm/llvm-project/commit/f11f382523e096859571b61520af81b9bb1defbf.diff

LOG: [AMDGPU] Fix declaration parameter names to match definition

This fixes the declaration of AMDGPULegalizerInfo::legalizeBufferLoad to
match the definition. It is still confusing that that parameter order is
different from legalizeBufferStore.

https://bugs.llvm.org/show_bug.cgi?id=47535

Added: 
    

Modified: 
    llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.h

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.h b/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.h
index 2fc7a0f698a7..e5f86511cd7c 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.h
+++ b/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.h
@@ -158,8 +158,8 @@ class AMDGPULegalizerInfo final : public LegalizerInfo {
                            MachineIRBuilder &B, bool IsTyped,
                            bool IsFormat) const;
   bool legalizeBufferLoad(MachineInstr &MI, MachineRegisterInfo &MRI,
-                          MachineIRBuilder &B, bool IsTyped,
-                          bool IsFormat) const;
+                          MachineIRBuilder &B, bool IsFormat,
+                          bool IsTyped) const;
   bool legalizeBufferAtomic(MachineInstr &MI, MachineIRBuilder &B,
                             Intrinsic::ID IID) const;
 


        


More information about the llvm-commits mailing list