[PATCH] D88213: [llvm-objcopy][NFC] refactor error handling. part 2.

Alexey Lapshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 25 03:10:07 PDT 2020


avl added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/COFF/COFFObjcopy.cpp:282
+    return createFileError(Config.InputFilename, O.takeError());
+  Object *Obj = O->get();
   assert(Obj && "Unable to deserialize COFF object");
----------------
mstorsjo wrote:
> This bit seems like unrelated renamings?
During previous review it was asked to not to use such naming style for similar case - https://reviews.llvm.org/D88113#inline-818190 . So I changed it to match with that requirement.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88213/new/

https://reviews.llvm.org/D88213



More information about the llvm-commits mailing list