[PATCH] D88256: [NFC][regalloc] Separate iteration from AllocationOrder

Wei Mi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 24 16:49:16 PDT 2020


wmi added a comment.

Is the intention to have multiple iterators live for the same AllocationOrder?



================
Comment at: llvm/lib/CodeGen/AllocationOrder.h:38-39
+  class Iterator final {
+    const ArrayRef<MCPhysReg> Hints;
+    const ArrayRef<MCPhysReg> Order;
+    int Pos = 0;
----------------
Can you have a reference of AllocationOrder in Iterator instead of defining multiple fields? It looks a little clearer to access parent's fields directly.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88256/new/

https://reviews.llvm.org/D88256



More information about the llvm-commits mailing list