[PATCH] D87813: [llvm] Add -bbsections-cold-text-prefix to emit cold clusters to a different section.

[Snehasish Kumar via Phabricator via llvm-commits]

snehasish marked 2 inline comments as done.
snehasish added a comment.

Thanks for the review.



================
Comment at: llvm/lib/CodeGen/BasicBlockSections.cpp:82
 
+// Placing the cold clusters in a separate section mitigates against poor
+// profiles and allows optimizations such as hugepage mapping to be applied at a
----------------
MaskRay wrote:
> I know your intention is that in practice users should specify .text.split. , however, the comment is a bit unclear that normally users should not use .text.unlikely.
Good idea, documented the prefix and relevant lld flag.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87813/new/

https://reviews.llvm.org/D87813