[PATCH] D79530: [lld][WebAssembly] Allow `atomics` feature with unshared memory

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 24 15:13:50 PDT 2020


sbc100 added a comment.
Herald added a subscriber: ecnelises.

Imagine a project that links statically without threads but its as dependency on some autoconf or cmake library that happens to throw in the `-pthread`... such users would hit this error today so I guess its only new users who do this that would be a runtime rather than link time error after this change.

Do you think this change makes it much hard to go from the error message to figuring out that you need to remove a stray `-pthread` from some CFLAGS somewhere?   At least the current error tells you which object is the problem.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79530/new/

https://reviews.llvm.org/D79530



More information about the llvm-commits mailing list