[PATCH] D85670: [Instruction] Add updateLocationAfterHoist helper

[Vedant Kumar via Phabricator via llvm-commits]

vsk added inline comments.


================
Comment at: llvm/unittests/IR/InstructionsTest.cpp:1350
+
+    EXPECT_FALSE(bool(I1->getDebugLoc()));
+    I1->dropLocation();
----------------
dblaikie wrote:
> Maybe these should be `EXPECT_EQ(I1->getDebugLoc(), DebugLoc());`? Would that work? Would hopefully give better failure messages by printing the values when the expect fails.
That does seem cleaner, thanks. I'll fix this up before committing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85670/new/

https://reviews.llvm.org/D85670