[PATCH] D87199: [lld-macho] Implement support for PIC

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 24 12:41:19 PDT 2020


int3 added inline comments.


================
Comment at: lld/MachO/SyntheticSections.cpp:165
+  llvm::sort(locations, [](const Location &a, const Location &b) {
+    return a.getVA() < b.getVA();
+  });
----------------
MaskRay wrote:
> If there are empty sections, there may be stability concerns.
we can't have a rebase entry pointing to an empty section though


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87199/new/

https://reviews.llvm.org/D87199



More information about the llvm-commits mailing list