[PATCH] D88200: [llvm-dwarfdump][test] Rewrite verify_die_ranges.s in YAML. NFC.

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.

Looks good - I don't feel that strongly about the split or merged commands.



================
Comment at: llvm/test/tools/llvm-dwarfdump/X86/verify_die_ranges.yaml:1
+# RUN: yaml2obj %s | not llvm-dwarfdump -verify - | FileCheck %s
+
----------------
jhenderson wrote:
> Whilst you're modifying this test, I'd split this up into separate yaml2obj and llvm-dwarfdump commands (i.e. no piping between the two) to make it easier to debug the test in the future.
FWIW, I tend to find the single command line easier to debug - don't have to worry about whether a test case has written a certain output file or not, etc. I can take the whole command line and know it's standalone/accounts for everything needed. (so if I rebuild llc I don't then have to go and dig up the applicable llc command, etc)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88200/new/

https://reviews.llvm.org/D88200