[PATCH] D88098: [SVE] Add new isKnownXX comparison functions to TypeSize

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 24 09:57:52 PDT 2020


sdesmalen added inline comments.


================
Comment at: llvm/include/llvm/Support/TypeSize.h:176
+
+  static bool isKnownLT(const TypeSize &LHS, const TypeSize &RHS) {
+    if (!LHS.IsScalable || RHS.IsScalable)
----------------
Sorry to spot this only after you've landed the patch, but was there an explicit reason for making these functions `static` as opposed to allowing the shorter `X.isKnownLT(Y)` (that wouldn't need the `TypeSize::` or `ElementCount::` prefix)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88098/new/

https://reviews.llvm.org/D88098



More information about the llvm-commits mailing list