[PATCH] D88165: IR: Have byref imply dereferenceable

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/test/Transforms/Attributor/value-simplify.ll:355
+; IS__CGSCC____-SAME: () [[ATTR1]] {
+; IS__CGSCC____-NEXT:    unreachable
 ;
----------------
arsenm wrote:
> arsenm wrote:
> > jdoerfert wrote:
> > > ups. Could you maybe repair the tests to avoid UB here?
> > I'm not sure what this is trying to test exactly. What argument should this pass instead?
> Just forwarding an argument seems to have worked
Add an argument and pass it along so this is not UB. The test checks we do not do anything invalid with a complicated argument (here inalloca)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88165/new/

https://reviews.llvm.org/D88165