[PATCH] D88199: Introduce and use a new section type for the bb_addr_map section.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Mostly looks okay. I think there is no testing for the assembly parser being able to parse the new section type?

I'm also keen to hear what others think (e.g. @MaskRay).



================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1026
 
-/// Returns the BB metadata to be emitted in the bb_addr_map section for a given
+/// Returns the BB metadata to be emitted in the .llvm_bb_addr_map section for a given
 /// basic block. This can be used to capture more precise profile information.
----------------
Please make sure to run clang-format on all the bits of code you've modified.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88199/new/

https://reviews.llvm.org/D88199