[PATCH] D86909: [lld-macho] Initial support for common symbols

[Greg McGary via Phabricator via llvm-commits]

gkm accepted this revision.
gkm added a comment.
This revision is now accepted and ready to land.

"Ship It"
llvm-logo <https://reviews.llvm.org/file/data/3w2fwhq6m5qun7n7mgbe/PHID-FILE-wwjqx32z6gheqvj7bwpq/meme-llvm-logo>



================
Comment at: lld/MachO/Driver.cpp:421
+// any CommonSymbols.
+static void replaceCommonSymbols() {
+  for (macho::Symbol *sym : symtab->getSymbols()) {
----------------
Nit, bordering on Super Nit:
Say more about the nature of this replacement
 - `replaceCommonSymbolsWithDefinedSymbols` ?
 - `defineCommonSymbols` ?
 - `upgradeCommonSymbolsToDefined` ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86909/new/

https://reviews.llvm.org/D86909