[PATCH] D87178: [lld-macho] Emit indirect symbol table

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 23 16:32:00 PDT 2020


int3 added inline comments.


================
Comment at: lld/MachO/SyntheticSections.h:392
+// The indirect symbol table is a list of 32-bit integers that serve as indices
+// into the (actual) symbol table. The indirect symbol table is composed of a
+// concatentation of several sub-arrays of indices, each sub-array belonging to
----------------
gkm wrote:
> English style nit.
Aren't they the same thing? Accordingly to Grammarly:

> Comprise is a verb that means “to be composed of.”

On second thought though it would be more accurate to say that "the indirect symbol table *is* a concatentation"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87178/new/

https://reviews.llvm.org/D87178



More information about the llvm-commits mailing list