[PATCH] D87178: [lld-macho] Emit indirect symbol table

[Greg McGary via Phabricator via llvm-commits]

gkm accepted this revision.
gkm added a comment.
This revision is now accepted and ready to land.

Very nice!



================
Comment at: lld/MachO/OutputSection.h:66-67
   uint32_t flags = 0;
+  uint32_t reserved1 = 0;
+  uint32_t reserved2 = 0;
 
----------------
Semantically blank names are beyond our reach in `struct section_64`, but `class OutputSection` is ours and we have the freedom to grant meaningful names. In `writeTo()` the assignments from members of `OutputSection` to `section_64` will make it clear how the meaningful names map onto the meaningless names.


================
Comment at: lld/MachO/SyntheticSections.h:392
+// The indirect symbol table is a list of 32-bit integers that serve as indices
+// into the (actual) symbol table. The indirect symbol table is composed of a
+// concatentation of several sub-arrays of indices, each sub-array belonging to
----------------
English style nit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87178/new/

https://reviews.llvm.org/D87178