[PATCH] D88169: [CMake][AIX] Set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR appropriately for AIX

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 23 15:11:20 PDT 2020


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/runtimes/CMakeLists.txt:263
 
+    set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR_default ON)
+    if (TARGET_TRIPLE MATCHES "aix")
----------------
Should there be a comment on this block too?


================
Comment at: llvm/runtimes/CMakeLists.txt:408
 
+    # AIX folds 32-bit & 64-bit arch libraries into a single archive.
+    set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR_default ON)
----------------
s/folds/should fold/;
I would suggest to move the comment to just before the AIX block.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88169/new/

https://reviews.llvm.org/D88169



More information about the llvm-commits mailing list