[PATCH] D87817: [LICM][Coroutine] Don't sink stores to coroutine suspend point.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/docs/Coroutines.rst:1561
+#. Make required changes to make sure not to insert or move any instructions
+   into edges from suspended(-1) case of coro.suspend intrinsics to their label.
+
----------------
junparser wrote:
> efriedma wrote:
> > This isn't what I was looking for.
> > 
> > Say I'm someone who doesn't know anything about coroutines, and I'm writing a new optimization.  What do I need to know about coroutines so I don't break them?
> The coroutine framework is designed to not interfere other transformation, Ideally, we do not need know anything about coroutine when write optimization. so this is still temporary fix. 
If you're not sure how it's supposed to work, I'm not sure we want to add temporary hacks before it's settled.

If you want to push forward with this anyway, please add comments to LICM to make it clear that this is a temporary state.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87817/new/

https://reviews.llvm.org/D87817