[PATCH] D88145: [ARM] Added more patterns to generate SSAT/USAT with shift

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 23 10:14:26 PDT 2020


dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMInstrInfo.td:4101
                (USAT imm0_31:$pos, GPRnopc:$a, asr_imm:$shft)>;
+def : ARMPat<(ARMssatnoshift (shl GPRnopc:$Rn, imm0_31:$shft), imm0_31:$pos),
+               (SSAT imm0_31:$pos, GPRnopc:$Rn, imm0_31:$shft)>;                            
----------------
Can you rename ARMssatnoshift to just ARMssat (or something similar). The "noshift" doesn't really need to be part of the node name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88145/new/

https://reviews.llvm.org/D88145



More information about the llvm-commits mailing list