[PATCH] D88167: [LoopDeletion] Forget loop before setting values to undef

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 23 10:13:33 PDT 2020


fhahn created this revision.
fhahn added reviewers: asbirlea, reames, mkazantsev.
Herald added subscribers: javed.absar, hiraditya.
Herald added a project: LLVM.
fhahn requested review of this revision.

After D71539 <https://reviews.llvm.org/D71539>, we need to forget the loop before setting the incoming
values of phi nodes in exit blocks, because we are looking through those
phi nodes now and the SCEV expression could depend on the loop phi. If
we update the phi nodes before forgetting the loop, we miss those users
during invalidation.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D88167

Files:
  llvm/lib/Transforms/Scalar/LoopDeletion.cpp
  llvm/lib/Transforms/Utils/LoopUtils.cpp
  llvm/test/Transforms/LoopDeletion/update-scev.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88167.293788.patch
Type: text/x-patch
Size: 7543 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200923/6db739a3/attachment.bin>


More information about the llvm-commits mailing list