[PATCH] D88157: [CMake] Make sure _cmake_system_name gets set

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/cmake/modules/LLVMExternalProjectUtils.cmake:55
 
+  # if CMAKE_SYSTEM_NAME doesn't get set, CMake will target the host.
+  if (NOT _cmake_system_name)
----------------
Capitalize as a sentence. Also, is this a statement about the behaviour of CMake (and we're just reflecting that locally through `_cmake_system_name`) or a statement about what this code is causing CMake to do? Please reword to clarify.

I would also suggest some editing of the patch description.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88157/new/

https://reviews.llvm.org/D88157