[PATCH] D87744: [RegisterCoalescer] passs Undefs to extendToIndices()

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 23 05:46:06 PDT 2020


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with test converted to generated checks



================
Comment at: llvm/test/CodeGen/AMDGPU/coalescer-removepartial-extend-undef-subrange.mir:1
+# RUN: llc -march=amdgcn -run-pass simple-register-coalescing -verify-machineinstrs -o - %s | FileCheck %s
+#
----------------
Add a -mcpu=gfx900 or some other target


================
Comment at: llvm/test/CodeGen/AMDGPU/coalescer-removepartial-extend-undef-subrange.mir:3-5
+# CHECK-LABEL: bb.1:
+# CHECK-NOT:     COPY
+# CHECK-LABEL: bb.2:
----------------
These checks are really weak, I would rather just generate these


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87744/new/

https://reviews.llvm.org/D87744



More information about the llvm-commits mailing list