[PATCH] D88082: [SystemZ] Make sure not to call getZExtValue on a >64 bit constant.

[Jonas Paulsson via Phabricator via llvm-commits]

jonpa updated this revision to Diff 293683.
jonpa marked 2 inline comments as done.
jonpa added a comment.

Thanks for review!

Patch updated per review with new test cases.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88082/new/

https://reviews.llvm.org/D88082

Files:
  llvm/lib/Target/SystemZ/SystemZTargetTransformInfo.cpp
  llvm/test/Analysis/CostModel/SystemZ/huge-immediates.ll


Index: llvm/test/Analysis/CostModel/SystemZ/huge-immediates.ll
===================================================================
--- /dev/null
+++ llvm/test/Analysis/CostModel/SystemZ/huge-immediates.ll
@@ -0,0 +1,20 @@
+; RUN: opt < %s -cost-model -analyze -mtriple=systemz-unknown -mcpu=z13
+;
+; Test that cost functions can handle immediates of more than 64 bits without crashing.
+
+; Cost of a load which is checked for folding into a compare w/ memory.
+define i32 @fun0(i72* %Src) {
+  %L = load i72, i72* %Src
+  %B = icmp ult i72 %L, 166153499473114484112
+  %Res = zext i1 %B to i32
+  ret i32 %Res
+}
+
+; Cost of a compare which is checked for elimination by Load and Test.
+define i32 @fun1(i72* %Src, i72* %Dst) {
+  %L = load i72, i72* %Src
+  store i72 %L, i72* %Dst
+  %B = icmp ult i72 %L, 166153499473114484112
+  %Res = zext i1 %B to i32
+  ret i32 %Res
+}
Index: llvm/lib/Target/SystemZ/SystemZTargetTransformInfo.cpp
===================================================================
--- llvm/lib/Target/SystemZ/SystemZTargetTransformInfo.cpp
+++ llvm/lib/Target/SystemZ/SystemZTargetTransformInfo.cpp
@@ -861,7 +861,7 @@
         if (LoadInst *Ld = dyn_cast<LoadInst>(I->getOperand(0)))
           if (const ConstantInt *C = dyn_cast<ConstantInt>(I->getOperand(1)))
             if (!Ld->hasOneUse() && Ld->getParent() == I->getParent() &&
-                C->getZExtValue() == 0)
+                C->isZero())
               return 0;
 
       unsigned Cost = 1;
@@ -1020,7 +1020,7 @@
     // Comparison between memory and immediate.
     if (UserI->getOpcode() == Instruction::ICmp)
       if (ConstantInt *CI = dyn_cast<ConstantInt>(UserI->getOperand(1)))
-        if (isUInt<16>(CI->getZExtValue()))
+        if (CI->getValue().isIntN(16))
           return true;
     return (LoadOrTruncBits == 32 || LoadOrTruncBits == 64);
     break;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88082.293683.patch
Type: text/x-patch
Size: 1869 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200923/375ca95e/attachment.bin>