[PATCH] D88043: [PowerPC] Add outer product instructions for MMA

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 22 16:35:39 PDT 2020


amyk added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:979
+
+// Defines 2 unmasked instructions where the xo field for acc/non-acc versioon
+// is even/odd.
----------------
s/versioon/version


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:1294
 
+// MMA accumulating/non-aaccumlating instructions.
+//------------------------------------------------------------------------------
----------------
s/aaccumlating/accumulating


================
Comment at: llvm/test/MC/PowerPC/ppc64-encoding-ISA31.s:35
             xxsetaccz 1
+# CHECK-BE: pmxvf16ger2 0, 1, 2, 4, 4, 2     # encoding: [0x07,0x90,0x80,0x44,
+# CHECK-BE-SAME:                                          0xec,0x01,0x10,0x98]
----------------
This is minor (and may not matter), but maybe we can align the `# encoding` lines together.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88043/new/

https://reviews.llvm.org/D88043



More information about the llvm-commits mailing list