[PATCH] D87852: [lld-macho] Allow the entry symbol to be dynamically bound

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 22 12:52:32 PDT 2020


smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

LGTM. It's interesting that this is a thing.



================
Comment at: lld/MachO/Writer.cpp:196
+      c->entryoff =
+          in.stubs->fileOff + config->entry->stubsIndex * target->stubSize;
+    else
----------------
Possible follow-up: I think this calculation is done in a bunch of places. Is there a nice place where a function for this calculation could live?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87852/new/

https://reviews.llvm.org/D87852



More information about the llvm-commits mailing list