[PATCH] D87988: [SystemZ] Optimize bcmp calls (PR47420)

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 22 10:57:44 PDT 2020


xbolva00 added a comment.

In D87988#2287804 <https://reviews.llvm.org/D87988#2287804>, @jonpa wrote:

> Maybe also have the test case from my original patch which transforms a memcmp to a bcmp...?
>
> If it is really ok to pass bcmp to visitMemCmpCall(), I think a comment on that specifies this would be nice, both for visitMemCmpCall() and EmitTargetCodeForMemcmp().

X86 emits same inline codegen for cmp and memcmp:
https://godbolt.org/z/W4dE1z

Right, I will adjust to make it more clear.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87988/new/

https://reviews.llvm.org/D87988



More information about the llvm-commits mailing list