[PATCH] D88054: [lld-macho] handle options -search_paths_first, -search_dylibs_first

Tue Sep 22 10:48:13 PDT 2020

gkm marked an inline comment as done.
gkm added inline comments.

================
Comment at: lld/test/MachO/link-search-order.s:26-28
+# PATHS-FIRST: @executable_path/libhello.dylib
+# PATHS-FIRST-NOT: @executable_path/libgoodbye.dylib
+# PATHS-FIRST: /usr/lib/libSystem.B.dylib
----------------
int3 wrote:
> nit: align the right column
I already submitted a major rework of the tests before seeing your comments. This open-source phabricator does not keep a history of diff revisions, so I can't see the original version on which you commented. Have a look at the latest and tell me if the right column still needs attention.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88054/new/

https://reviews.llvm.org/D88054