[PATCH] D88072: [X86] Improve demanded bits for X86ISD::BEXTR.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 22 10:39:01 PDT 2020


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:38341
+      if (Length == 0) {
+        Known.setAllZero();
+        return false;
----------------
RKSimon wrote:
> Return a new zero constant if we manage to get here?
Doesn't the caller already do that when all demanded bits are known?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88072/new/

https://reviews.llvm.org/D88072



More information about the llvm-commits mailing list