[PATCH] D88104: [GlobalISel] Combine (xor (and x, y), y) -> (and (not x), y)

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 22 10:19:25 PDT 2020


aemerson added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:2679
+
+  if (Y != SharedReg)
+    std::swap(X, Y);
----------------
This code is a bit big-brain for me this morning. Simplify this to `return X == SharedReg || Y == SharedReg`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88104/new/

https://reviews.llvm.org/D88104



More information about the llvm-commits mailing list