[PATCH] D88063: [SelectionDAG] Make sure FMF are propagated when getSetcc canonicalizes FP constants to RHS.

[Qiu Chaofan via Phabricator via llvm-commits]

qiucf added a comment.

In D88063#2287835 <https://reviews.llvm.org/D88063#2287835>, @spatel wrote:

> What, if any, interaction is there between this and D87361 <https://reviews.llvm.org/D87361>? 
> Can we solve this with the more general flag propagation scheme proposed there?

I think yes, but here the issue is `getSetCC` uses a default empty argument for `Flags`, just like how `getNode` do. If split it into two versions like D87361 <https://reviews.llvm.org/D87361>, one as normal but `Flags` is explicitly required, the other for no `Flags` and use the flags from current inserter (or remove `Flags` argument, if provide `setFlags` to flags inserter for rare cases when we want to pass a different flag), we can do it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88063/new/

https://reviews.llvm.org/D88063