[PATCH] D88035: [AArch64] Teach analyzeBranch to remove branch equivelent to fallthrough

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 22 08:07:17 PDT 2020


reames added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:307
+    if (I == MBB.begin() || !isUnpredicatedTerminator(*--I)) {
+      if (isUncondBranchOpcode(LastOpc)) {
+        TBB = LastInst->getOperand(0).getMBB();
----------------
resistor wrote:
> What's the situation where this is needed?
Looking at it, that one should be dead.  I'll convert to an assert to confirm.

The conditional branch case below is definitely not dead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88035/new/

https://reviews.llvm.org/D88035



More information about the llvm-commits mailing list