[PATCH] D88094: [lld][test][ELF] Expand a couple of test cases for LTO behaviour

Tue Sep 22 07:34:00 PDT 2020

grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

LGTM with a comment added. Please wait for @MaskRay.

================
Comment at: lld/test/ELF/lto/weak.ll:10
+; RUN: llvm-as %t/2.ll -o %t2.bc
+; RUN: llc %t/4.ll -o %t4.o -filetype=obj
+
----------------
nit: I was a bit confused looking at these names at first. I searched for `3.ll` for some time until realized the naming rule used.
Perhaps, `size1.ll`, `size2.ll` and `size4.ll` names (and the same for *.bc) could be a bit clearer. Though, now I am fine with original naming too, so up to you.

================
Comment at: lld/test/ELF/reproduce-lto.s:3

 # RUN: rm -rf %t.dir
 # RUN: mkdir -p %t.dir/build1
----------------
I'd suggest adding a comment about what exactly is tested while are you here.
Like is said in the description probably:
"Show that the bitcode files are stored in the reproduce package and that intermediate files (such as the LTO-compiled object) are not".

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88094/new/

https://reviews.llvm.org/D88094