[PATCH] D88097: [llvm-readelf/obj] - Cleanup the code. NFCI.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 22 07:07:26 PDT 2020


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
Herald added subscribers: rupprecht, kristof.beyls.
Herald added a project: LLVM.
grimar requested review of this revision.

This:

1. Replaces pointers with references in many places.
2. Adds few TODOs about fixing possible unhandled errors (in ARMEHABIPrinter.h).
3. Replaces `auto`s with actual types.
4. Removes excessive arguments.
5. Adds `const ELFFile<ELFT> &Obj;` member to `ELFDumper` to simplify the code.


https://reviews.llvm.org/D88097

Files:
  llvm/tools/llvm-readobj/ARMEHABIPrinter.h
  llvm/tools/llvm-readobj/DwarfCFIEHPrinter.h
  llvm/tools/llvm-readobj/ELFDumper.cpp
  llvm/tools/llvm-readobj/ObjDumper.cpp
  llvm/tools/llvm-readobj/ObjDumper.h
  llvm/tools/llvm-readobj/llvm-readobj.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88097.293450.patch
Type: text/x-patch
Size: 105012 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200922/dc77eb87/attachment.bin>


More information about the llvm-commits mailing list