[PATCH] D87867: [NFC][ScheduleDAG] Remove unused EntrySU SUnit

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 22 06:55:58 PDT 2020


fhahn added a comment.

In D87867#2285957 <https://reviews.llvm.org/D87867#2285957>, @thegameg wrote:

> I am totally fine with keeping this in-tree, even unused, if it helps several out-of-tree backends. Thanks for speaking up.
>
> Maybe someone using it can provide an explanation of potential uses of this node as a comment in `ScheduleDAG.h`?

It's perfectly fine to keep it, but it would be good to have something use it in tree upstream, otherwise we have zero test coverage.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87867/new/

https://reviews.llvm.org/D87867



More information about the llvm-commits mailing list