[PATCH] D88066: [InstCombine] For pow(x, +/-0.5), stop falling into pow(x, 1.5), etc. case

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 22 06:15:50 PDT 2020


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/test/Transforms/InstCombine/pow-4.ll:240-241
+; SQRT-LABEL: @shrink_pow_libcall_half(
+; SQRT-NEXT:    [[SQRTF:%.*]] = call fast float @sqrtf(float [[X:%.*]])
+; SQRT-NEXT:    [[SQRTF1:%.*]] = call fast float @sqrtf(float [[X]])
+; SQRT-NEXT:    ret float [[SQRTF1]]
----------------
That looks like another bug. We formed an extra sqrtf() call from a not-quite-dead pow() call?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88066/new/

https://reviews.llvm.org/D88066



More information about the llvm-commits mailing list