[PATCH] D87378: [SVE] Fix InstCombinerImpl::PromoteCastOfAllocation for scalable vectors

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 22 06:07:29 PDT 2020


sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

LGTM, thanks for the changes @david-arm!



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCasts.cpp:142
+  // We don't currently support arrays of scalable types.
+  if (AllocIsScalable && (ArraySizeScale != 0 || ArrayOffset != 1))
+    return nullptr;
----------------
If arrays of scalable types are not supported, this should be an `assert`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87378/new/

https://reviews.llvm.org/D87378



More information about the llvm-commits mailing list