[PATCH] D87153: [RFC PATCH 1] BPF: move AbstractMemberAccess and PreserveDIType passes to EP_EarlyAsPossible

Mon Sep 21 21:03:32 PDT 2020

yonghong-song added inline comments.

================
Comment at: llvm/lib/Target/BPF/BPFAbstractMemberAccess.cpp:1072
+  //   - insert a call and mark it with NoMerge function attribute.
+  // We use __builtin_bpf_passthrough() call marked with NoMerge approach.
+  // Compared to inline assembly approach, this has less impact on inlining
----------------
ast wrote:
> why did you remove the whole comment? Only 'NoMerge' part of it is no longer relevant, right?
> But the rest is still very helpful to understand the intent or I'm missing something?
Okay, NoMerge part is irrelevant now. The sequence number of will prevent any kind of merging/CSE, not just tail merging. I will restore the comments.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87153/new/

https://reviews.llvm.org/D87153