[PATCH] D88056: [gn build] Allow option to build with asan/tsan/ubsan

Mon Sep 21 16:47:09 PDT 2020

aeubanks added a comment.

In D88056#2286494 <https://reviews.llvm.org/D88056#2286494>, @vitalybuka wrote:

> In D88056#2286473 <https://reviews.llvm.org/D88056#2286473>, @vitalybuka wrote:
>
>> In D88056#2286450 <https://reviews.llvm.org/D88056#2286450>, @aeubanks wrote:
>>
>>> I got asan to fire on some out of bounds stuff with this change, but couldn't get ubsan to trigger on integer overflow for some reason. -fsanitize=undefined is in the ninja files, so maybe I just didn't trip it in the right way.
>
> I assume you are asking about the same code which triggers asan and you expect some ubsan report there.
> Never mind if the question was about -fsanitize=signed-integer-overflow

Poorly worded on my part, I meant -fsanitize=signed-integer-overflow on different code. (I was trying to repro a bot failure caught by ubsan but couldn't repro it with this, I was wondering if I got something wrong, but separately was able to get asan to trigger on some bad code, so at least I know that the flags are probably correct)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88056/new/

https://reviews.llvm.org/D88056