[PATCH] D87233: [POC][DebugInfo] Use entry values within IR

Orlando Cazalet-Hyams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 21 05:38:42 PDT 2020


Orlando added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/Local.cpp:1596
 
+Value *llvm::findEntryValue(DIVariable *Var) {
+  // TODO: Find an entry value for local variables,
----------------
Hi @djtodoro. IIUC this function assumes that the returned `dbg.value` - the first one we find - for parameter variable `Var` uses the corresponding argument value (as opposed to some other value that a mutable parameter could be assigned). If that is correct, why is that assumption safe?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87233/new/

https://reviews.llvm.org/D87233



More information about the llvm-commits mailing list