[PATCH] D87899: [llvm-readobj/elf] - Stop reporting invalid extended indexes in warnings for unnamed section symbols.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 21 01:13:52 PDT 2020
jhenderson added a comment.
In D87899#2284145 <https://reviews.llvm.org/D87899#2284145>, @MaskRay wrote:
> All the passing of `FirstSym` is for `&Sym - &FirstSym` in ELF.h getExtendedSymbolTableIndex. If we only care about the index, passing around the index rather than the first symbol probably makes more sense?
+1 - this makes sense to me too. Everything else looks good.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87899/new/
https://reviews.llvm.org/D87899
More information about the llvm-commits
mailing list