[PATCH] D85626: [tools][remarks-shlib] Don't build libRemarks.so without PIC

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg accepted this revision.
thegameg added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/tools/remarks-shlib/CMakeLists.txt:1-2
-set(LLVM_LINK_COMPONENTS
-  Remarks
-  )
+# Building shared libraries requires PIC objects.
+if(LLVM_ENABLE_PIC)
+
----------------
ro wrote:
> lebedev.ri wrote:
> > Is this the only LLVM shared library that was missing this `if(LLVM_ENABLE_PIC)` check?
> > If not, this comment is misleading, since clearly it worked so far everywhere else.
> No, `LLVMPolly.so` had the same issue: fixed in D85627.
Possibly `libLTO.so` too? But maybe it doesn't get built during `check-all` on your platform. There is `LLVM_TOOL_LTO_BUILD` but from what I see it's never checked.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85626/new/

https://reviews.llvm.org/D85626