[PATCH] D87905: [AArch64] Fix ldst optimization of non-immediate store offset

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:1190
+    // And make sure the store instruction is in 'reg+imm' form as the load
+    // instruction.
     if (MI.mayStore() && isMatchingStore(LoadMI, MI) &&
----------------
Also, maybe fix this comment to clarify what the problem is.  The store should be an opcode that can use an immediate operand. The problem is that the "immediate" might actually be the address of a global variable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87905/new/

https://reviews.llvm.org/D87905