[PATCH] D52367: Remove address taken, add optnone

[David Blaikie via Phabricator via llvm-commits]

dblaikie commandeered this revision.
dblaikie edited reviewers, added: hiraditya; removed: dblaikie.
dblaikie added inline comments.
This revision is now accepted and ready to land.


================
Comment at: test/Transforms/HotColdSplit/split-cold-1.ll:29
+; CHECK-NOT: codeRepl:
+define void @bar() noinline optnone {
+entry:
----------------
aeubanks wrote:
> dblaikie wrote:
> > I'm guessing if this is marked "noinline" then this test wouldn't fail with the patch not applied? (because it'd be caught by the noinline case a few lines later - producing the same behavior)
> > 
> > With the "noinline" removed, does this test fail without the patch applied?
> This patch shouldn't be necessary, optnone requires noinline:
> ```
> $ cat /tmp/a.ll
> define void @test1() optnone {
>   ret void
> }
> $ bin/opt.exe -verify -disable-output /tmp/a.ll
> Attribute 'optnone' requires 'noinline'!
> void ()* @test1
> C:\src\llvm-project\build\rel\bin\opt.exe: C:/src/tmp/a.ll: error: input module is broken!
> ```
Great! Given how old the patch is, I'll just commandeer and abandon it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52367/new/

https://reviews.llvm.org/D52367