[PATCH] D87870: [GISel] Add new combines for G_FMUL

Michael Kitzan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 18 13:17:36 PDT 2020


mkitzan added inline comments.


================
Comment at: llvm/include/llvm/Target/GlobalISel/Combine.td:299
+// Fold (x op 0.0) - > 0.0
+def binop_right_to_fp_zero: GICombineRule<
+  (defs root:$root),
----------------
jurahul wrote:
> Sorry to comment on a change that I know nothing about, but ts this somewhere checking if fast math or equivalent is enabled? Otherwise, X * 0.0 != 0.0 in floating point. 
At the moment nothing is checking whether fast math of special flags are enabled, but perhaps it should.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87870/new/

https://reviews.llvm.org/D87870



More information about the llvm-commits mailing list