[PATCH] D87335: [json] Create some llvm::Expected-based accessors

walter erquinigo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 18 12:44:57 PDT 2020


wallace added a comment.

Thanks for the review. I'll implement this as helper functions in my patch, however it'd be interesting to figure out a way to create this API so that callers don't recreate this functionality. My general understanding is that showing some error message, even if incomplete, is better than showing almost nothing. But I can understand your point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87335/new/

https://reviews.llvm.org/D87335



More information about the llvm-commits mailing list