[PATCH] D86977: [IRSim][IROutliner] Limit to extracting regions that only require inputs

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 18 11:06:51 PDT 2020


paquette added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:335
+
+void IROutliner::findAddInputsOutputs(
+    Module &M, OutlinableRegion &Region) {
----------------
Does `IgnoreRegion` have to be a member variable at all?

Maybe make this and `getCodeExtractorArguments` return a bool?

e.g.

```
return getCodeExtractorArguments(Region, Inputs, ArgInputs);
```

Then the caller of this function can just check whether or not this function succeeded via the bool?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86977/new/

https://reviews.llvm.org/D86977



More information about the llvm-commits mailing list