[PATCH] D87296: [IRSim][IROutliner] Adding support for consolidating functions with different output arguments.

Jon Roelofs via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 18 09:22:33 PDT 2020


jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:838
+      if (isa<DbgInfoIntrinsic>(Inst))
+        continue;
+
----------------
jroelofs wrote:
> What if `FIt` has debug/lifetime instructions that `BB` doesn't? The dual iteration thing going on here seems... iffy.
Much better, thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87296/new/

https://reviews.llvm.org/D87296



More information about the llvm-commits mailing list